github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-22 22:56:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

repmgrd: sanity check for presence of follow/promote commands

Browse Source 
Autofailover will fail if either is missing.
This commit is contained in:
Ian Barwick
2017-06-23 18:54:45 +09:00
parent 71146aef9d
commit 9566dc49f3
1 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
repmgrd.c
View File

@@ -226,7 +226,7 @@ main(int argc, char **argv)
if (verbose)
logger_set_verbose();
log_info(_("connecting to database '%s'"),
log_info(_("connecting to database \"%s\""),
config_file_options.conninfo);
local_conn = establish_db_connection(config_file_options.conninfo, true);
@@ -291,6 +291,35 @@ main(int argc, char **argv)
}
if (config_file_options.failover_mode == FAILOVER_AUTOMATIC)
{
/*
* check that promote/follow commands are defined, otherwise repmgrd
* won't be able to perform any useful action
*/
bool required_param_missing = false;
if (config_file_options.promote_command[0] == '\0'
&& config_file_options.service_promote_command[0] == '\0')
{
log_error(_("either \"promote_command\" or \"service_promote_command\" must be defined in the configuration file"));
required_param_missing = true;
}
if (config_file_options.follow_command[0] == '\0')
{
log_error(_("\"follow_command\" must be defined in the configuration file"));
required_param_missing = true;
}
if (required_param_missing == true)
{
log_hint(_("add the missing configuration parameter(s) and start repmgrd again"));
PQfinish(local_conn);
exit(ERR_BAD_CONFIG);
}
}
if (daemonize == true)
{
daemonize_process();
@@ -305,11 +334,8 @@ main(int argc, char **argv)
setup_event_handlers();
#endif
start_monitoring();
/* shut down logging system */
logger_shutdown();
return SUCCESS;
@@ -341,7 +367,6 @@ start_monitoring(void)
/* should never happen */
break;
}
}
}