github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-22 22:56:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

repmgr: during switchover check demotion candidate's pidfile

Browse Source 
If the pidfile is still there after apparent shutdown, or we're
unable to access the server at all, something has gone wrong and
the switchover should be aborted.
This commit is contained in:
Ian Barwick
2016-07-01 09:42:55 +09:00
parent 69d9d137e0
commit a0f02e454c
1 changed files with 27 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
repmgr.c
View File

@@ -2751,7 +2751,7 @@ do_standby_switchover(void)
int server_version_num;
bool use_pg_rewind;
/* the remote server is the primary which will be demoted */
/* the remote server is the primary to be demoted */
char remote_conninfo[MAXCONNINFO] = "";
char remote_host[MAXLEN];
char remote_data_directory[MAXLEN];
@@ -3200,16 +3200,38 @@ do_standby_switchover(void)
/* database server could not be contacted */
if (ping_res == PQPING_NO_RESPONSE)
{
bool command_success;
/*
* XXX here we should directly access the server and check that the
* directly access the server and check that the
* pidfile has gone away so we can be sure the server is actually
* shut down and the PQPING_NO_RESPONSE is not due to other issues
* such as coincidental network failure.
*/
shutdown_success = true;
initPQExpBuffer(&command_output);
log_notice(_("current master has been stopped\n"));
break;
maxlen_snprintf(command,
"ls %s/postmaster.pid >/dev/null 2>&1 && echo 1 || echo 0",
remote_data_directory);
command_success = remote_command(
remote_host,
runtime_options.remote_user,
command,
&command_output);
if (command_success == true && *command_output.data == '0')
{
shutdown_success = true;
log_notice(_("current master has been stopped\n"));
termPQExpBuffer(&command_output);
break;
}
termPQExpBuffer(&command_output);
}
/* XXX make configurable? */