github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-23 07:06:30 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

Avoid defining variable-length arrays

Browse Source 
As of PostgreSQL commit d9dd406f, variable length arrays are no longer
permitted. As they're not actually required anyway, just define appropriate
constants.

Also noted in GitHub #510.
This commit is contained in:
Ian Barwick
2018-10-26 10:09:45 +09:00
parent 4f0b10cac6
commit a554914854
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dbutils.c
View File

@@ -30,6 +30,8 @@
#include "controldata.h"
#include "dirutil.h"
#define NODE_RECORD_PARAM_COUNT 11
/* mainly for use by repmgrd */
int server_version_num = UNKNOWN_SERVER_VERSION_NUM;
@@ -2478,8 +2480,8 @@ _create_update_node_record(PGconn *conn, char *action, t_node_info *node_info)
char *slot_name_ptr = NULL;
int param_count = 11;
const char *param_values[param_count];
int param_count = NODE_RECORD_PARAM_COUNT;
const char *param_values[NODE_RECORD_PARAM_COUNT];
PGresult *res;
bool success = true;

6
repmgr.c
View File

@@ -58,7 +58,7 @@
#define TRANCHE_NAME "repmgrd"
#define REPMGRD_STATE_FILE PGSTAT_STAT_PERMANENT_DIRECTORY "/repmgrd_state.txt"
#define REPMGRD_STATE_FILE_BUF_SIZE 128
PG_MODULE_MAGIC;
@@ -256,8 +256,8 @@ set_local_node_id(PG_FUNCTION_ARGS)
if (file != NULL)
{
int buffer_size = 128;
char buffer[buffer_size];
int buffer_size = REPMGRD_STATE_FILE_BUF_SIZE;
char buffer[REPMGRD_STATE_FILE_BUF_SIZE];
if (fgets(buffer, buffer_size, file) != NULL)
{