github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-22 22:56:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity

standby clone: fixes for Barman tablespace handling.

Browse Source 
repmgr creates a file with a list of tablespace files to fetch from
Barman, however the file may not actually have been flushed to disk
at the point the rsync operation was executed, so may be incomplete
or empty.

Also fix handling of tablespace remapping.

Addresses GitHub #650.
This commit is contained in:
Ian Barwick
2020-06-09 10:51:37 +09:00
parent a2f73a5086
commit ca42dd563b
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
repmgr-action-standby.c
View File

@@ -7026,11 +7026,13 @@ run_file_backup(t_node_info *local_node_record)
if (mode == barman)
{
create_pg_dir(cell_t->location, false);
create_pg_dir(tblspc_dir_dest, false);
if (cell_t->f != NULL) /* cell_t->f == NULL iff the tablespace is
* empty */
{
fclose(cell_t->f);
maxlen_snprintf(command,
"rsync --progress -a --files-from=%s/%s.txt %s:%s/%s/%s %s",
local_repmgr_tmp_directory,
@@ -7043,7 +7045,6 @@ run_file_backup(t_node_info *local_node_record)
(void) local_command(
command,
NULL);
fclose(cell_t->f);
maxlen_snprintf(filename,
"%s/%s.txt",
local_repmgr_tmp_directory,
@@ -7160,7 +7161,10 @@ stop_backup:
if (mode == barman)
{
/* In Barman mode, remove local_repmgr_directory */
/*
* In Barman mode, remove local_repmgr_tmp_directory,
* which contains various temporary files containing Barman metadata.
*/
rmtree(local_repmgr_tmp_directory, true);
}