mirror of
https://github.com/EnterpriseDB/repmgr.git
synced 2026-03-22 22:56:29 +00:00
repmgrd: when reloading configuration, log any errors encountered
This commit is contained in:
21
configfile.c
21
configfile.c
@@ -1075,17 +1075,36 @@ reload_config(t_configuration_options *orig_options)
|
||||
static ItemList config_errors = {NULL, NULL};
|
||||
static ItemList config_warnings = {NULL, NULL};
|
||||
|
||||
PQExpBufferData errors;
|
||||
|
||||
log_info(_("reloading configuration file"));
|
||||
|
||||
_parse_config(&new_options, &config_errors, &config_warnings);
|
||||
|
||||
if (config_errors.head != NULL)
|
||||
{
|
||||
/* XXX dump errors to log */
|
||||
ItemListCell *cell = NULL;
|
||||
|
||||
log_warning(_("unable to parse new configuration, retaining current configuration"));
|
||||
|
||||
initPQExpBuffer(&errors);
|
||||
|
||||
appendPQExpBuffer(&errors,
|
||||
"following errors were detected:\n");
|
||||
|
||||
for (cell = config_errors.head; cell; cell = cell->next)
|
||||
{
|
||||
appendPQExpBuffer(&errors,
|
||||
" %s\n", cell->string);
|
||||
}
|
||||
|
||||
log_detail("%s", errors.data);
|
||||
termPQExpBuffer(&errors);
|
||||
return false;
|
||||
}
|
||||
|
||||
|
||||
|
||||
/* The following options cannot be changed */
|
||||
|
||||
if (new_options.node_id != orig_options->node_id)
|
||||
|
||||
Reference in New Issue
Block a user