Commit Graph

518 Commits

Author SHA1 Message Date
Ian Barwick
355d8b8f01 Use InvalidXLogRecPtr for pedantic correctness 2015-01-13 13:47:22 +09:00
Ian Barwick
8df7966540 Rename variable
"find_best" sounds like an imperative.
2015-01-13 13:42:30 +09:00
Ian Barwick
1a790549ea Refactor if-statement 2015-01-13 13:40:47 +09:00
Ian Barwick
b80d25ad33 Add some hopefully correct comments for future reference
Also some debugging output which will need to be removed later.
2015-01-13 11:12:20 +09:00
Ian Barwick
a1a61e5ec3 Remove unneeded include 2015-01-13 07:57:54 +09:00
Ian Barwick
1221b73293 repmgrd: explicitly state INSERT statement target columns 2015-01-12 20:47:22 +09:00
Ian Barwick
93d5d7905f Remove "XL*" macros and rationalize XLogRecPtr handling
As of 9.3, XLogRecPtr is a uint64, which makes it much easier to
handle, so we can retire the legacy macros and work directly
with the values.
2015-01-12 17:18:57 +09:00
Ian Barwick
41a5274b44 Comment for consistency 2015-01-12 15:30:17 +09:00
Ian Barwick
d9f83cf620 Replace hard-coded value with local_options.reconnect_attempts; 2015-01-12 14:09:44 +09:00
Ian Barwick
905a2d0a5e Have witness server retry determining the new master
Loop a few times before giving up
2015-01-12 14:05:37 +09:00
Ian Barwick
526803c5e0 Witness server should always try to re-connect to primary
Standbys will try to reconnect even in MANUAL_FAILOVER mode,
so it's consistent to have the witness server do that too.
2015-01-12 13:32:04 +09:00
Ian Barwick
2ff24fecf2 Remove redundant constant 2015-01-12 13:16:13 +09:00
Ian Barwick
a5ead16d6f Change query to use COUNT(*)
No point implying we're fetching the entire record
2015-01-12 12:28:06 +09:00
Ian Barwick
5fb84b9627 Witness server: on failover attempt to reconnect to new master
Previously it was just quitting.
2015-01-12 11:23:20 +09:00
Ian Barwick
437485bf6a Fix debugging output 2015-01-12 09:47:13 +09:00
Ian Barwick
822867ec24 Fix thinko 2015-01-12 09:40:47 +09:00
Ian Barwick
5b88a980b8 Add some debugging output 2015-01-12 07:57:42 +09:00
Ian Barwick
e958b8f2d7 Fix typo 2015-01-09 18:44:31 +09:00
Ian Barwick
74a963a10e Fix schema quoting
There was a lot of duplicated/unused related to handling the
schema name; consolidated and rationalised.
2015-01-09 15:51:34 +09:00
Ian Barwick
dd064cb47c res1 -> res 2015-01-09 11:20:07 +09:00
Ian Barwick
17de82493a Consolidate repl_node insert statements 2015-01-09 11:14:47 +09:00
Ian Barwick
f2fa60f5cf Tidy up SQL statements
Improves readability
2015-01-09 09:46:41 +09:00
Ian Barwick
acf2744ed7 Replace magic number with defined constant
And use it to restrict the number of rows retrieved to avoid
overflowing the array.
2015-01-08 17:19:02 +09:00
Ian Barwick
7bafd490c1 Remove #define for pre-9.3 versions 2015-01-08 16:59:10 +09:00
Ian Barwick
7c15176646 Clean up comments 2015-01-08 14:04:43 +09:00
Ian Barwick
97cbd7d557 Remove superfluous variable 2015-01-08 13:23:33 +09:00
Ian Barwick
5798241205 Add 'recovery_target_timeline = latest' to recovery.conf
Also revert to generating our own recovery.conf rather than using
pg_basebackup's minimal file.
2015-01-08 10:46:49 +09:00
Ian Barwick
5b5b4cd4cd Remove redundant comment 2015-01-08 09:51:53 +09:00
Ian Barwick
9dd78f34db Add missing short options to --help output 2015-01-07 08:56:05 +09:00
Ian Barwick
a5b5e3d384 No need to store master version number here 2015-01-07 08:55:17 +09:00
Ian Barwick
241622694d Remove support for pre-9.3 servers 2015-01-06 14:53:26 +09:00
Ian Barwick
687872e979 get_data_directory() -> get_pg_setting()
More code consolidation
2015-01-06 13:47:31 +09:00
Ian Barwick
3033f2dfaf Fix get_cluster_size()
Was returning a pointer to a cleared PQresult
2015-01-06 10:30:33 +09:00
Ian Barwick
718024454e Add function get_data_directory()
Consolidate duplicate code
2015-01-06 10:06:58 +09:00
Ian Barwick
e3379c0fbf Bump minimum supported version to 9.3
We need to assume the existence of timeline switch following by
standbys.
2015-01-06 08:29:57 +09:00
Ian Barwick
ba4413ce91 Change any log messages using 'master' to 'primary'
For consistency, as 'master' is the preferred terminology in repmgr
2015-01-06 08:19:48 +09:00
Ian Barwick
e85e0732ef Nope, no real point doing that here 2015-01-05 22:55:58 +09:00
Ian Barwick
97fb3dbb14 Have 'standby promote' use 'pg_ctl promote' 2015-01-05 21:28:11 +09:00
Ian Barwick
8e09e7b57c Fix error code handling 2015-01-05 10:49:21 +09:00
Ian Barwick
4f37515113 Pass username to pg_basebackup 2015-01-05 10:29:02 +09:00
Ian Barwick
413cc6eb54 Add todo comment 2015-01-05 09:37:30 +09:00
Ian Barwick
f23c43b986 Clean up exit error codes 2015-01-05 09:36:48 +09:00
Ian Barwick
38de150436 Fix spelling 2015-01-05 09:23:26 +09:00
Ian Barwick
a80da61203 Remove unneeded parameters 2015-01-04 17:10:29 +09:00
Ian Barwick
4fbe8ca70e copy_remote_files() now only needs to copy individual files
In which case rsync should be an atomic operation
2015-01-04 16:03:27 +09:00
Ian Barwick
1aa12a122f Selectively copy configuration files if not in master data directory 2015-01-04 15:59:07 +09:00
Ian Barwick
c54d5f9a9c Add check for max_wal_senders > 0 on master 2015-01-04 08:31:52 +09:00
Ian Barwick
db49206fc5 Clean up logging output 2015-01-04 08:25:50 +09:00
Ian Barwick
017f66e15e Make --check-master-config state no problems found 2015-01-04 08:15:11 +09:00
Ian Barwick
e06949db87 Add option --check-master-config
Consolidate the configuration checks carried out when cloning
a standby, and enable them to be run separately to check the
required configuration without running STANDBY CLONE multiple times.
2015-01-03 11:29:00 +09:00