Christian Kruse
98b1f8d28a
rather big refactoring: use a naming scheme
...
In the past naming of functions, variables and such didn't really have a
naming scheme. Now they should have.
2014-03-06 18:34:40 +01:00
Christian Kruse
9eba986833
avoid usage of snprintf()
...
We have a nice little abstraction for snprintf with covering the case
that a string is too big for the target buffer – let's use that!
2014-03-06 18:34:40 +01:00
Christian Kruse
164cf9d08f
completely avoid usage of strnlen()
2014-03-06 18:34:40 +01:00
Christian Kruse
d8b8bf0e2a
pg_indent'ing all files…
2014-03-06 18:34:40 +01:00
Christian Kruse
fed5c77653
various improvements and bugfixes in the init script
2014-03-06 15:23:22 +01:00
Christian Kruse
8429b43edf
Merge pull request #14 from wamonite/fix_follow_user
...
fix: store the master connection user name on standby follow
2014-03-06 15:20:02 +01:00
Warren Moore
7e55ce737d
fix: store the master connection user name on standby follow
2014-03-05 16:49:56 +00:00
Christian Kruse
98c7635fb5
fixing more compiler warnings
2014-03-04 17:58:36 +01:00
Christian Kruse
90ecb2b107
fix: check return values of freopen()
...
Some compiles complain about not checking the return value of freopen(),
so we check it
2014-03-04 15:32:48 +01:00
Christian Kruse
50b9022a41
fix: don't use Windows newlines
2014-03-04 12:59:23 +01:00
Christian Kruse
150ccc0662
add option to avoid repmgrd started upon installation
...
Now repmgr.repmgrd.default has another option: REPMGRD_ENABLED. Valid
values are either yes or no.
2014-03-04 12:46:05 +01:00
Christian Kruse
0ff14a2aa1
avoid compiler warnings
2014-02-21 13:47:29 +01:00
Christian Kruse
5215265694
fix: now CloseConnections() is much more safe
2014-02-18 17:06:36 +01:00
Christian Kruse
e45ac25348
fix: progname is const, do not free it
...
The leak is irrelevant
2014-02-18 16:45:35 +01:00
Christian Kruse
a1ce01f033
fix: fixed some leaks
2014-02-18 16:35:29 +01:00
Christian Kruse
516cde621a
fix: strcpy() on overlapping memory regions is invalid
2014-02-18 15:42:20 +01:00
Christian Kruse
f0807923a3
fix: gettimeofday() expects two arguments
2014-02-18 15:33:56 +01:00
Christian Kruse
10ca8037f8
added some more log messages
...
Now we should be able to distinguish different events more easily
2014-02-18 14:10:12 +01:00
Christian Kruse
0dc46f0dc8
fix: set connection to NULL when finishing it
...
This will avoid CloseConnections() to try to close an already closed connection.
2014-02-18 13:42:49 +01:00
Christian Kruse
c3b58658ad
fixing repmgr repl_status columns
...
repmgr repl_status had the column time_lag which was documented to be
the time a standby is behind master. In fact it only works like this
when viewed on the standby and not on the master: there it only was the
time of the last status update. We dropped that column and replaced it
by a new column „communication_time_lag“ which is the content of the
repl_status column on the master. On the standby we contain the time of
the last update in shared mem though refer always to the correct time
nonetheless where repl_status is queried. We also added a new column,
„replication_time_lag“, which refers to the apply delay.
2014-02-15 01:35:27 +01:00
Christian Kruse
18f1fed77f
fixing wait_connection_availability()
...
wait_connection_availability() did take at least 2 seconds per call in
the old incarnation. Now we may finish a call without any sleep at all
when the result is already ready at the time called
2014-02-15 01:31:12 +01:00
Christian Kruse
d58fd080ca
flush stderr after a log message appears
...
We had the problem that the log file appeared empty for a long time due
to file buffers. Thus we call fflush() after every log message so the
log file gets written out to disk quickly
2014-02-15 01:29:12 +01:00
Christian Kruse
c4ac2d3343
fixing PQexec() calls
...
fixing several calls where we did not check the result status but only
the return value; the query may fail nonetheless
2014-02-15 01:27:53 +01:00
Christian Kruse
5ff1beeea7
do not enable autofailover by default
...
Autofailover is an experimental feature which should not be enabled by
default. The user has to be aware of what he is doing when enabling it.
2014-02-11 09:27:31 +01:00
Christian Kruse
ca470647cb
cleanup of usage text
...
Now it properly aligns and breaks at 78 characters.
2014-01-30 14:26:17 +01:00
Christian Kruse
62ee287e3f
updated TODO
2014-01-30 14:10:14 +01:00
Christian Kruse
729a1b848a
release notes for 2.0 stable
2014-01-30 13:59:17 +01:00
Christian Kruse
701cf043fd
fix: seems as if I missread -hackers
2014-01-23 16:46:49 +01:00
Christian Kruse
bbb67c55f6
simple past of set is set
2014-01-23 10:50:37 +01:00
Christian Kruse
c2c48a9fe6
removed already finished TODO tasks
2014-01-23 10:48:04 +01:00
Christian Kruse
9d6ac2ebf9
fixed documentation and line endings
2014-01-23 10:39:21 +01:00
Christian Kruse
680f23fb1d
copyright push
2014-01-23 10:37:49 +01:00
Christian Kruse
1159113c58
ignore the dynamic shared memory directory, too
2014-01-23 10:02:32 +01:00
Christian Kruse
f25a709454
added an explicit type cast to avoid compiler warnings
2014-01-22 15:17:47 +01:00
Christian Kruse
897daddcc7
removed not needed arguments to avoid compiler warnings
2014-01-22 15:17:28 +01:00
Christian Kruse
0fdcce0477
use if instead of switch and avoid a warning
2014-01-22 15:12:29 +01:00
Christian Kruse
de58eff7c1
added a chdir() for proper daemonizing
2014-01-22 14:30:38 +01:00
Christian Kruse
f2a0b31a20
more log format fixes
2014-01-22 14:30:24 +01:00
Christian Kruse
e007a55967
fix: do not use fsync()
...
We do not need fsync(), the fflush() is enough to avoid concurrent
logs.
2014-01-22 11:47:50 +01:00
Christian Kruse
d235c696af
fix: do not newline at the start of a log line
...
This breaks the log file format since it will have a line break directly
after the timestamp
2014-01-22 11:47:02 +01:00
Christian Kruse
4ef6fbb5fe
do not close stderr but reopen it to /dev/null
...
We want stderr to be always a valid file descriptor
2014-01-21 16:25:57 +01:00
Christian Kruse
2e61d7b156
refactoring: daemonizing is now a function
2014-01-21 16:19:49 +01:00
Christian Kruse
4496a0761e
we now use a function and are more sophisticated
...
Refactoring part: we now use a function to generate the PID
file. Sophistication: we now check if the PID contained in the file is a
valid PID. We ignore the file if it doesn't.
2014-01-21 16:18:15 +01:00
Christian Kruse
3978ead184
use a second fork to avoid a terminal
...
after the setsid() we are the process leader. And as a process leader we
are able to open a new terminal, even if we currently don't own one. So
we do another fork and do not call setsid() and not become a process
leader to avoid that.
2014-01-21 15:51:33 +01:00
Christian Kruse
b36dbf61fe
reopening stdin and stdout to /dev/null now
...
stdin, stdout and stderr should always be valid file handles. Thus we
don't close them but reopen them to /dev/null
2014-01-21 15:31:38 +01:00
Christian Kruse
84466ecca5
log_crit() is more appropriate
2014-01-21 15:23:20 +01:00
Christian Kruse
649086e5e4
use unlink() instead of remove()
...
`remove()` will do a rmdir if necessary - we don't want that. So we use `unlink()`
2014-01-21 15:22:31 +01:00
Christian Kruse
7cf2eb440d
renamed config options to a much more descriptive name
2014-01-21 15:19:50 +01:00
Christian Kruse
388bbfb773
split install target into install_prog and install_ext
...
Patch by Marco Nenciarini <mnencia@debian.org >
2014-01-21 14:23:33 +01:00
Christian Kruse
a89aa02c68
fix: make pg_config be settable from outside the makefile
...
Patch by Marco Nenciarini <mnencia@debian.org >
2014-01-21 14:22:59 +01:00
