Commit Graph

913 Commits

Author SHA1 Message Date
Ian Barwick
acc0ffa81f Add -L/--log-level command line option to repmgr
Overrides any setting in the config file. This will replace the
-v/--verbose option.
2015-11-30 16:14:54 +09:00
Ian Barwick
1725e90308 Change directory warning to a hint 2015-11-30 16:14:44 +09:00
Ian Barwick
2a3fb89603 Explicitly mark static functions as static 2015-11-30 16:14:39 +09:00
Ian Barwick
8f24167f68 detect_log_level(): return -1 to indicate invalid log level
0 is EMERG, which is not actually used but is valid. Prior to this
change, repmgr would complain about an invalid log level if set to
this.
2015-11-30 16:14:31 +09:00
Ian Barwick
6ce94778d7 README.md: add note about setting repmgr user search path 2015-11-30 16:14:25 +09:00
Ian Barwick
3a3c6d5143 Add TODO items 2015-11-30 16:14:18 +09:00
Ian Barwick
73661637e9 Add hint about -c/--fast-checkpoint
When cloning a server without this option, and pg_start_backup() takes time
to complete, repmgr appears to hang and give no indication of what may
or may not be happening. The hint provides an explanation for any
delay and possible action which could be taken to mitigate it.
2015-11-30 16:14:13 +09:00
Ian Barwick
ae84041a4e Add log_hint() function for logging hints
There are a few places where additional hints are written as log
output, usually LOG_NOTICE. Create an explicit function to provide
hints in a standardized manner; by storing the log level of the
previous logger call, we can ensure the hint is only displayed when
the log message itself would be.

Part of an ongoing effort to better control repmgr's logging output.
2015-11-30 16:14:08 +09:00
Ian Barwick
ea01d1d30b Always use catalog path when calling system functions
Removes any risk of issues due to search path mangling etc.
2015-11-30 16:13:31 +09:00
Ian Barwick
53ed8e948c Clean up help output
master/primary register only has one option
2015-11-30 16:13:22 +09:00
Ian Barwick
43626892d0 Improve configuration file parsing
Related to Github #127.

- use the previously introduced repmgr_atoi() function to parse
  integers better
- collate all detected errors and output as a list, rather than
  failing on the first error.
2015-11-30 16:13:16 +09:00
Ian Barwick
8870b7d7f1 Rename variable 'reconnect_intvl' to 'reconnect_interval'
For consistency with the configuration file parameter name
2015-11-30 16:13:08 +09:00
Ian Barwick
72b1e57251 Use strtol() to parse config file arguments too 2015-11-30 16:13:01 +09:00
Ian Barwick
6054da2c25 Use strtol() in place of atoi() to better verify integer parameters
Per GitHub #127
2015-11-30 16:12:30 +09:00
Ian Barwick
049ea4e24f cluster cleanup: standardize error message and return code 2015-11-30 16:12:19 +09:00
Ian Barwick
5f8185ef3a Fix log wording 2015-11-30 16:12:13 +09:00
Ian Barwick
66a6c15773 Add informtative logging output for 'repmgr cluster cleanup'
Per Github issue #126.
2015-11-30 16:12:06 +09:00
Ian Barwick
919fc0fbef "How many" -> "Number of" 2015-11-30 16:11:57 +09:00
Ian Barwick
c7c117130b "in 9.4" -> "from 9.4" 2015-11-30 16:11:52 +09:00
Ian Barwick
df6517f167 Add note about logfile rotation and repmgrd 2015-11-30 16:11:47 +09:00
Ian Barwick
0bf3fb0605 Point out existence of the FAQ 2015-11-30 16:11:41 +09:00
Ian Barwick
c2172d79a5 Wording tweak to prevent ambiguity. 2015-11-30 16:11:35 +09:00
Ian Barwick
709276a19c Add TODO item 2015-11-30 16:11:27 +09:00
Ian Barwick
3f98e1b91b Replace "slave" with "standby" for consistency
"standby" is used everywhere except in these two error messages.
2015-11-30 16:11:21 +09:00
Ian Barwick
8af08ab3f4 Remove duplicated TODO item
Conflicts:
	TODO
2015-11-30 16:11:01 +09:00
Ian Barwick
ff038a5148 Update HISTORY 2015-11-30 16:10:04 +09:00
Ian Barwick
f56f70c2a6 Specify relevant node in error message 2015-11-30 16:09:59 +09:00
Ian Barwick
d353fe2a9f Terminate repmgrd if standby is no longer connected to upstream 2015-11-30 16:09:50 +09:00
Ian Barwick
a70a44605f Update FAQ entry about witness port specification 2015-11-30 16:09:41 +09:00
Ian Barwick
d14dcb3d8b Add FAQ item about repmgr permissions in pg_hba.conf 2015-11-30 16:09:28 +09:00
Ian Barwick
249ac7c72a Update TODO 2015-11-30 16:09:19 +09:00
Ian Barwick
9d850fc4bd Add note about default log level 2015-11-30 16:09:14 +09:00
Ian Barwick
42cb811a07 Put declarations at top of file 2015-11-30 16:09:08 +09:00
Ian Barwick
1e202540e3 Explicitly set default value for 'use_replication_slots' 2015-11-30 16:09:01 +09:00
Ian Barwick
52db03d320 Add 'primary_response_timeout' as synonym for 'master_response_timeout'
We'll switch terminology in a future release and maintain
'master_response_timeout' for backwards compatibility
2015-11-30 16:08:56 +09:00
Ian Barwick
60d720f0c7 Clarify items in the sample repmgr.conf file
Based on customer feedback.
2015-11-30 16:08:47 +09:00
Ian Barwick
34af7dec2a Use pg_malloc0() instead of malloc()
See also d08bd352c1
2015-11-30 16:08:39 +09:00
Ian Barwick
a59ea243c0 Improve logging and event notifications when following new upstream node 2015-11-30 16:08:30 +09:00
Ian Barwick
0c5025b3d6 Add note about checking replication slots when following upstream node 2015-11-30 16:08:07 +09:00
Ian Barwick
42b79b9b54 Improve log messages when following new primary 2015-11-30 16:07:39 +09:00
Ian Barwick
2e47c6b40b Minor formatting tweak 2015-11-30 16:07:32 +09:00
Ian Barwick
6fbff4747f Clarify some items in sample config file
Also change "master" to "primary" in the comments for consistency
with main PostgreSQL terminology. We'll need to add aliases
for the configuration parameters at some point...
2015-11-30 16:07:23 +09:00
Ian Barwick
cc567d38c8 Update TODO
Conflicts:
	TODO
2015-11-30 16:04:39 +09:00
Ian Barwick
69c552b8e0 Only log some debug items if verbose flag is set. 2015-11-30 16:03:56 +09:00
Ian Barwick
51967d2bd8 Add missing space 2015-11-30 16:03:50 +09:00
Ian Barwick
97be9c0cda Reword log level error message to be more like the Postgres one 2015-11-30 16:03:43 +09:00
Ian Barwick
00a28fbb1e Clarify purpose of get_repmgr_schema() 2015-11-30 16:03:17 +09:00
Ian Barwick
d512bac31d Clean up --help output
There are a confusing number of command line options, some
of which are only valid for particular operations, e.g. "standby clone".
2015-11-30 16:02:59 +09:00
Martín Marqués
fb6781775d Fix bug which prevents repmgrd from starting when the cluster name has
upper case letters.
2015-10-08 19:46:34 -03:00
Ian Barwick
04c751a912 Update HISTORY 2015-10-02 14:40:28 +09:00