github/repmgr
1
0
Fork 0
mirror of https://github.com/EnterpriseDB/repmgr.git synced 2026-03-24 15:46:29 +00:00
Code Issues Packages Projects Releases 1 Wiki Activity
944 Commits 43 Branches 68 Tags
f6d1db5edb3d6e248d05dfee5f080d1c8ccac58f
Commit Graph

944 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ian Barwick
66844d057a Rename 'need_a_node' to 'config_file_required' 2015-03-20 14:56:02 +09:00
Ian Barwick
f096cca84f Fix parameter checking for STANDBY CLONE 
Previous check for the master host was ineffective. We'd be better off explicitly
requiring at least hostname, database and usernames for the master rather
than relying on whatever defaults were in place when STANDBY CLONE is
run, especially as dbname and username are used in recovery.conf.
 2015-03-20 14:47:04 +09:00
Ian Barwick
0fbb83262f Rename t_configuration_options member 'pgctl_options' to 'pg_ctl_options' 
Change is to make it match the actual configuration item.
 2015-03-20 11:02:32 +09:00
Ian Barwick
a0a3ef58b0 Remove item "Timeline increases when promoting a standby" 
Covered by `pg_ctl promote`.
 2015-03-20 10:42:07 +09:00
Ian Barwick
b007fc8b39 3.0rc4 2015-03-19 23:28:40 +09:00
Ian Barwick
ae19c9bd5d Only execute pg_stop_backup() if pg_start_backup() was previously executed 
It's not a problem per-se but produces some unnecessary and possibly
confusing errors.
 2015-03-19 23:19:34 +09:00
Ian Barwick
1b4a8917ca Transfer hint in error message to its own log notice 2015-03-19 23:12:39 +09:00
Ian Barwick
ce66a7c2d2 We shouldn't terminate with an error if no event record could be created 
Event records are advisory and non-critical; there may be paths
where we're not able to connect to a valid master and hence unable
to write a record. (If an 'event_notification_command' is defined,
this should serve as a backup notification of the event).
 2015-03-19 23:09:29 +09:00
Ian Barwick
9a3196b671 Add a hint if 'standby register' fails due to insert error 2015-03-19 23:01:31 +09:00
Ian Barwick
46a3082055 No need for log_event() function 2015-03-19 22:49:50 +09:00
Ian Barwick
ebabc68f8a Add recovery.conf file location and contents to debugging output 2015-03-19 22:15:45 +09:00
Ian Barwick
c757985640 primary -> master 
For consistency
 2015-03-19 11:26:47 +09:00
Ian Barwick
172a3d90cf Terminate rather than destroy 2015-03-19 09:55:20 +09:00
Ian Barwick
86d24759a0 In configuration check, check that 'archive_command' is not empty 2015-03-18 16:07:34 +09:00
Ian Barwick
7bd54b5a70 3.0rc3 2015-03-17 23:16:18 +09:00
Ian Barwick
3e04c8e720 Event logging and notifications 2015-03-17 20:10:00 +09:00
Ian Barwick
7f98bb7aec Create event record for rempgrd termination 
Also fix a few incorrect exit codes.
 2015-03-17 19:08:59 +09:00
Ian Barwick
9e2736be4c Remove superfluous configuration check 
Also add note about configuration parsing failure and event logging.
 2015-03-17 18:41:17 +09:00
Ian Barwick
4b3966d6a7 Update HISTORY 2015-03-17 16:07:04 +09:00
Ian Barwick
5a1036cea2 Update and rework repmgr.conf.sample 2015-03-17 14:13:46 +09:00
Ian Barwick
e21448831d Standardize configuration error messages for 'failover' parameter. 
Better to fail with an error than assume a default value if an
unrecognized value is detected.
 2015-03-17 08:19:29 +09:00
Ian Barwick
155f5075cb Improve configuration error and warning messages 2015-03-17 08:14:27 +09:00
Ian Barwick
9cfd6680b3 Remove superfluous comment 2015-03-17 08:01:09 +09:00
Ian Barwick
874616f149 Add %n/node id format option for 'event_notification_command' 2015-03-16 18:04:50 +09:00
Ian Barwick
61ce18ebbe Add configuration parameter 'event_notifications' 2015-03-16 17:31:26 +09:00
Ian Barwick
922dfd88e5 Add configuration option 'event_notification_command' 
Command to be executed each time an event is logged.

Following formatting sequences will be interpolated:

      %e - event type
      %d - description
      %s - success (1 or 0)
      %t - timestamp
 2015-03-16 13:41:13 +09:00
Ian Barwick
b41235b896 Tweak code comments 2015-03-16 09:31:08 +09:00
Ian Barwick
0307c51d4b Add initial event logging code 2015-03-16 07:44:54 +09:00
Abhijit Menon-Sen
6d608aea7f Merge pull request #50 from wking/autofailover-quick-setup-copy-edits 
autofailover_quick_setup.rst: Assorted copy edits
 2015-03-15 23:13:28 +05:30
W. Trevor King
5d26e27b48 autofailover_quick_setup.rst: '$(...)' for command substitution 
Both are in POSIX [1], but the dollar-paren form is nicer [2].

[1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_03
[2]: http://mywiki.wooledge.org/BashFAQ/082
 2015-03-14 12:13:22 -07:00
W. Trevor King
2fa2dfff95 autofailover_quick_setup.rst: Double-colon before literal block 2015-03-14 12:00:30 -07:00
W. Trevor King
9e5b3e0a2d autofailover_quick_setup.rst: Replace tabs with spaces 
Before this commit there was inconsistency over the indentation.  This
commit consolidates around two spaces.
 2015-03-14 11:59:46 -07:00
W. Trevor King
e0b82393b0 autofailover_quick_setup.rst: Restructure notes about witness server information 
Avoid repeating "it needs", and explain that the superuser password it
needs is for the witness database (and not a sudo password, or a
superuser on the production database).
 2015-03-14 11:56:36 -07:00
W. Trevor King
5c64f09889 autofailover_quick_setup.rst: 'failover procedure' -> 'the failover procedure' 2015-03-14 11:50:47 -07:00
W. Trevor King
af7dee05a4 autofailover_quick_setup.rst: 'it is needed' -> 'you need' 
Drop the passive voice.
 2015-03-14 11:49:10 -07:00
W. Trevor King
bdb8ee1a6f autofailover_quick_setup.rst: 'Clone the node1' -> 'Clone node1' 
This sounds better to me, but maybe that's just my American dialect
:p.  The issue of what name get articles is complicated [1].

[1]: http://english.stackexchange.com/questions/59271/why-there-is-the-before-some-names-but-not-others
 2015-03-14 11:43:54 -07:00
W. Trevor King
3799d089a1 autofailover_quick_setup.rst: 'Log in' -> 'Log in to' 
For some discussion, see [1].

[1]: http://english.stackexchange.com/questions/5302/log-in-to-or-log-into-or-login-to
 2015-03-14 11:40:37 -07:00
W. Trevor King
d06bd0ddea autofailover_quick_setup.rst: 'allows setups' -> 'allows for' 2015-03-14 11:34:42 -07:00
W. Trevor King
7fed433df1 autofailover_quick_setup.rst: 'hostname fully qualified' -> FQDN 
This is the usual terminology [1].

[1]: http://en.wikipedia.org/wiki/Fully_qualified_domain_name
 2015-03-14 11:33:54 -07:00
W. Trevor King
9517624297 autofailover_quick_setup.rst: Replace 'server used for witness' 
With 'witness server' in most places.

When defining the nodes, I went with 'server used as a witness', since
'**witness** is the hostname ... of the witness server' sounded like a
tautology.  The longer phrasing isn't really any different, but it
sounds better to me ;).
 2015-03-14 11:33:53 -07:00
W. Trevor King
25ea635689 autofailover_quick_setup.rst: Reword 'failover need to vote' 
And some other minor tweaks to this paragraph.  I split the
witness-repmgrd bit off into its own sentence, since that's pretty
independent of the voting business.
 2015-03-14 11:33:53 -07:00
W. Trevor King
0d971d9009 autofailover_quick_setup.rst: Reword name-with-status caution 
Fix the 'recommanded' typo and reword to drop the passive voice and
some awkward phrasing.
 2015-03-14 11:32:11 -07:00
W. Trevor King
5bba37cebd autofailover_quick_setup.rst: Replace 'fail-over' with 'failover' 
Use the more common spelling.  Before this commit:

  $ git grep -i failover | wc -l
  67
  $ git grep -i fail-over | wc -l
  2
 2015-03-14 11:17:46 -07:00
Abhijit Menon-Sen
886a9fd036 A couple of items for later 2015-03-13 16:15:53 +05:30
Abhijit Menon-Sen
94d0d119f6 Fix typo 2015-03-13 16:15:53 +05:30
Ian Barwick
96c8cd4148 Update code comments 2015-03-13 16:43:12 +09:00
Ian Barwick
619f95d85c Update code comments 2015-03-13 12:49:06 +09:00
Ian Barwick
97ae6dbf57 Remove superfluous configuration check 
This is already done in parse_config()
 2015-03-13 12:04:08 +09:00
Ian Barwick
2929ed9be0 Make parameters 'conninfo' and 'node_name' mandatory 
There's no reason why they need to be absent; if absent they're
likely to cause confusion.
 2015-03-13 11:57:34 +09:00
Ian Barwick
33037dd7fb Explicitly specify problematic parameter names in error messages. 2015-03-13 11:47:28 +09:00