Add primary_node_info inline function

When a t_node_info struct must be re initilised, it was re-declared only. Moreover, a macro was user for any var creation of this type impeding use the same to reset the values later if needed. This new function allows to re initilise again a t_node_info typed variable without the need to redeclare it to create other varibles for the same purpose, and also shadowing is now avoided from pg16. Macros seems to be replaced by `static inline` functions in upstream postgres, credits to Alvaro Herrera <alvherre@alvh.no-ip.org> for this idea. References: HL-40
Fix shadowed declaration
2026-03-23 15:16:29 +00:00 · 2024-11-15 10:52:52 -03:00 · 2024-11-15 10:52:52 -03:00
7 changed files with 26 additions and 63 deletions
--- a/7
+++ b/7
@@ -1,9 +1,4 @@
-5.5.0   2024-11-20
-        Support for PostgreSQL 17 added
-        Fix warnings detected by the -Wshadow=compatible-local
-          added in PostgreSQL 16
-
-5.4.1   2023-07-04
+5.4.1   2023-??-??
        repmgrd: ensure witness node metadata is updated (Ian)

 5.4.0   2023-03-16
--- a/README.md
+++ b/README.md
@@ -68,6 +68,7 @@ news are always welcome.

 Thanks from the repmgr core team.

+* Ian Barwick
 * Israel Barth
 * Mario González
 * Martín Marqués
@@ -75,7 +76,6 @@ Thanks from the repmgr core team.

 Past contributors:

-* Ian Barwick
 * Jaime Casanova
 * Abhijit Menon-Sen
 * Simon Riggs
--- a/doc/appendix-release-notes.xml
+++ b/doc/appendix-release-notes.xml
@@ -16,24 +16,9 @@
  </para>

  <!-- remember to update the release date in ../repmgr_version.h.in -->
-
-  <sect1 id="release-5.5.0">
-    <title>Release 5.5.0</title>
-    <para><emphasis>Wed 20 November, 2024</emphasis></para>
-    <para>
-      &repmgr; 5.5.0 is a major release.
-    </para>
-    <para>
-      This release adds support for PostgreSQL 17
-    </para>
-    <para>
-      Fixes warnings detected by the -Wshadow gcc flag added in PostgreSQL 16.
-    </para>
-  </sect1>
-
  <sect1 id="release-5.4.1">
    <title id="release-current">Release 5.4.1</title>
-    <para><emphasis>Tue 04 Jul, 2023</emphasis></para>
+    <para><emphasis>??? ?? ??????, 202?</emphasis></para>
    <para>
      &repmgr; 5.4.1 is a minor release providing ...
    </para>
--- a/doc/install-requirements.xml
+++ b/doc/install-requirements.xml
@@ -14,7 +14,7 @@
  </para>

  <para>
-   &repmgr; &repmgrversion; is compatible with all supported PostgreSQL versions from 13.x. See
+   &repmgr; &repmgrversion; is compatible with all PostgreSQL versions from 9.4. See
   section <link linkend="install-compatibility-matrix">&repmgr; compatibility matrix</link>
   for an overview of version compatibility.
  </para>
@@ -45,7 +45,7 @@
     of incompatibilities.
   </simpara>
   <simpara>
-     If different &quot;major&quot; &repmgr; versions (e.g. 5.2.x and &repmgrversion;)
+     If different &quot;major&quot; &repmgr; versions (e.g. 4.1.x and &repmgrversion;.x)
     are installed on different nodes, in the best case &repmgr; (in particular &repmgrd;)
     will not run. In the worst case, you will end up with a broken cluster.
   </simpara>
@@ -89,6 +89,7 @@
      which PostgreSQL version.
    </para>

+
    <table id="repmgr-compatibility-matrix">
      <title>&repmgr; compatibility matrix</title>

@@ -116,16 +117,16 @@
        <tbody>
          <row>
            <entry>
-              &repmgr; 5.5
+              &repmgr; 5.4
            </entry>
            <entry>
-              Yes
+              (dev)
            </entry>
            <entry>
-              <link linkend="release-5.5.0">&repmgrversion;</link> (&releasedate;)
+              <link linkend="release-current">&repmgrversion;</link> (&releasedate;)
            </entry>
            <entry>
-              13, 14, 15, 16, 17
+              9.4, 9.5, 9.6, 10, 11, 12, 13, 15
            </entry>
            <entry>
              &nbsp;
@@ -134,31 +135,13 @@

          <row>
            <entry>
-              &repmgr; 5.4.1
+              &repmgr; 5.3
            </entry>
            <entry>
-              Yes
+              YES
            </entry>
            <entry>
-              <link linkend="release-5.4.1">5.4.1</link> (2023-04-04)
-            </entry>
-            <entry>
-              10, 11, 12, 13, 14, 15
-            </entry>
-            <entry>
-              &nbsp;
-            </entry>
-          </row>
-
-          <row>
-            <entry>
-              &repmgr; 5.3.1
-            </entry>
-            <entry>
-              Yes
-            </entry>
-            <entry>
-              <link linkend="release-5.3.1">5.3.1</link> (2022-02-15)
+              <link linkend="release-current">&repmgrversion;</link> (&releasedate;)
            </entry>
            <entry>
              9.4, 9.5, 9.6, 10, 11, 12, 13, 14, 15
@@ -173,7 +156,7 @@
              &repmgr; 5.2
            </entry>
            <entry>
-              No
+              NO
            </entry>
            <entry>
              <link linkend="release-5.2.1">5.2.1</link> (2020-12-07)
@@ -191,7 +174,7 @@
              &repmgr; 5.1
            </entry>
            <entry>
-              No
+              NO
            </entry>
            <entry>
              <link linkend="release-5.1.0">5.1.0</link> (2020-04-13)
@@ -209,7 +192,7 @@
              &repmgr; 5.0
            </entry>
            <entry>
-              No
+              NO
            </entry>
            <entry>
              <link linkend="release-5.0">5.0</link> (2019-10-15)
@@ -228,7 +211,7 @@
              &repmgr; 4.x
            </entry>
            <entry>
-              No
+              NO
            </entry>
            <entry>
              <link linkend="release-4.4">4.4</link> (2019-06-27)
@@ -246,7 +229,7 @@
              &repmgr; 3.x
            </entry>
            <entry>
-              No
+              NO
            </entry>
            <entry>
              <ulink url="https://repmgr.org/release-notes-3.3.2.html">3.3.2</ulink> (2017-05-30)
@@ -264,7 +247,7 @@
              &repmgr; 2.x
            </entry>
            <entry>
-              No
+              NO
            </entry>
            <entry>
              <ulink url="https://repmgr.org/release-notes-2.0.3.html">2.0.3</ulink> (2015-04-16)
@@ -283,12 +266,12 @@

    <important>
      <para>
-        The &repmgr; series older than 5.x are no longer maintained or supported.
+        The &repmgr; 2.x and 3.x series are no longer maintained or supported.
        We strongly recommend  upgrading to the latest &repmgr; version.
      </para>
      <para>
        Following the release of &repmgr; 5.0, there will be no further releases of
-        the &repmgr; 4.x series or older. Note that &repmgr; 5.x is an incremental development
+        the &repmgr; 4.x series. Note that &repmgr; 5.x is an incremental development
        of the 4.x series and &repmgr; 4.x users should upgrade to this as soon as possible.
      </para>
    </important>
--- a/doc/legal.xml
+++ b/doc/legal.xml
@@ -1,9 +1,9 @@
 <!-- doc/legal.xml -->

-<date>2025</date>
+<date>2022</date>

 <copyright>
- <year>2010-2025</year>
+ <year>2010-2022</year>
 <holder>EDB</holder>
 </copyright>

@@ -11,7 +11,7 @@
 <title>Legal Notice</title>

 <para>
-  <productname>repmgr</productname> is Copyright &copy; 2010-2025
+  <productname>repmgr</productname> is Copyright &copy; 2010-2022
  by EDB All rights reserved.
 </para>

--- a/doc/repmgr.xml
+++ b/doc/repmgr.xml
@@ -26,7 +26,7 @@
  <abstract>
   <para>
   This is the official documentation of &repmgr; &repmgrversion; for
-   use with PostgreSQL 12 - PostgreSQL 17.
+   use with PostgreSQL 9.4 - PostgreSQL 15.
   </para>
   <para>
     &repmgr; is being continually developed and we strongly recommend using the
--- a/repmgr.control
+++ b/repmgr.control
@@ -1,6 +1,6 @@
 # repmgr extension
 comment = 'Replication manager for PostgreSQL'
-default_version = '5.5'
+default_version = '5.4'
 module_pathname = '$libdir/repmgr'
 relocatable = false
 schema = repmgr