docs: finalize release notes

Bump version number
2026-03-23 07:06:30 +00:00 · 2022-02-15 13:38:24 +09:00 · 2022-02-04 09:08:04 +09:00 · 2022-02-03 14:48:47 +09:00 · 2022-02-03 14:32:18 +09:00 · 2022-02-03 13:30:29 +09:00
11 changed files with 80 additions and 44 deletions
--- a/3
+++ b/3
@@ -1,3 +1,6 @@
+5.3.1   2022-??-??
+        repmgrd: fixes for potential connection leaks (hslightdb)
+
 5.3.0   2021-10-12
        standby switchover: improve handling of node rejoin failure (Ian)
        repmgrd: prefix all shared library functions with "repmgr_" to
--- a/configure.in
+++ b/configure.in
@@ -1,4 +1,4 @@
-AC_INIT([repmgr], [5.3.0], [repmgr@googlegroups.com], [repmgr], [https://repmgr.org/])
+AC_INIT([repmgr], [5.3.1], [repmgr@googlegroups.com], [repmgr], [https://repmgr.org/])

 AC_COPYRIGHT([Copyright (c) 2010-2021, EnterpriseDB Corporation])

--- a/doc/appendix-release-notes.xml
+++ b/doc/appendix-release-notes.xml
@@ -16,8 +16,38 @@
  </para>

 <!-- remember to update the release date in ../repmgr_version.h.in -->
+  <sect1 id="release-5.3.1">
+    <title id="release-current">Release 5.3.1</title>
+    <para><emphasis>Tue 15 February, 2022</emphasis></para>
+    <para>
+      &repmgr; 5.3.1 is a minor release.
+    </para>
+    <sect2>
+      <title>Bug fixes</title>
+      <para>
+        <itemizedlist>
+           <listitem>
+             <para>
+               Fix upgrade path from &repmgr; 4.2 and 4.3 to &repmgr; 5.3.
+             </para>
+           </listitem>
+           <listitem>
+             <para>
+               &repmgrd;: ensure potentially open connections are closed.
+             </para>
+             <para>
+                In some cases, when recovering from degraded state in local node monitoring,
+                new connection was opened to the local node without closing
+                the old one, which will result in memory leakage.
+             </para>
+           </listitem>
+        </itemizedlist>
+      </para>
+    </sect2>
+  </sect1>
+
  <sect1 id="release-5.3.0">
-    <title id="release-current">Release 5.3.0</title>
+    <title>Release 5.3.0</title>
    <para><emphasis>Tue 12 October, 2021</emphasis></para>
    <para>
      &repmgr; 5.3.0 is a major release.
--- a/doc/configuration-file.xml
+++ b/doc/configuration-file.xml
@@ -262,7 +262,7 @@ conninfo='host=node1 user=repmgr dbname=repmgr connect_timeout=2'</programlistin

    <indexterm>
      <primary>repmgr.conf</primary>
-      <secondary>ostgreSQL major version upgrades</secondary>
+      <secondary>PostgreSQL major version upgrades</secondary>
    </indexterm>

    <para>
--- a/doc/install-requirements.xml
+++ b/doc/install-requirements.xml
@@ -112,10 +112,9 @@
        </thead>

        <tbody>
-
          <row>
            <entry>
-              &repmgr; 5.2
+              &repmgr; 5.3
            </entry>
            <entry>
              YES
@@ -123,6 +122,21 @@
            <entry>
              <link linkend="release-current">&repmgrversion;</link> (&releasedate;)
            </entry>
+            <entry>
+              9.4, 9.5, 9.6, 10, 11, 12, 13, 14
+            </entry>
+          </row>
+
+          <row>
+            <entry>
+              &repmgr; 5.2
+            </entry>
+            <entry>
+              NO
+            </entry>
+            <entry>
+              <link linkend="release-5.2.1">5.2.1</link> (2020-12-07)
+            </entry>
            <entry>
              9.4, 9.5, 9.6, 10, 11, 12, 13
            </entry>
--- a/repmgr--4.2--4.3.sql
+++ b/repmgr--4.2--4.3.sql
@@ -1,17 +1,10 @@
 -- complain if script is sourced in psql, rather than via CREATE EXTENSION
-\echo Use "CREATE EXTENSION repmgr" to load this file. \quit
+\echo Use "ALTER EXTENSION repmgr UPDATE" to load this file. \quit

-CREATE FUNCTION set_upstream_last_seen()
-  RETURNS VOID
-  AS 'MODULE_PATHNAME', 'set_upstream_last_seen'
-  LANGUAGE C STRICT;
+-- This script is intentionally empty and exists to skip the CREATE FUNCTION
+-- commands contained in the 4.2--4.3 and 4.3--4.4 extension upgrade scripts,
+-- which reference C functions which no longer exist in 5.3 and later.
+--
+-- These functions will be explicitly created in the 5.2--5.3 extension
+-- upgrade step with the correct C function references.

-CREATE FUNCTION get_upstream_last_seen()
-  RETURNS INT
-  AS 'MODULE_PATHNAME', 'get_upstream_last_seen'
-  LANGUAGE C STRICT;
-
-CREATE FUNCTION get_wal_receiver_pid()
-  RETURNS INT
-  AS 'MODULE_PATHNAME', 'get_wal_receiver_pid'
-  LANGUAGE C STRICT;
--- a/repmgr--4.3--4.4.sql
+++ b/repmgr--4.3--4.4.sql
@@ -1,19 +1,9 @@
 -- complain if script is sourced in psql, rather than via CREATE EXTENSION
-\echo Use "CREATE EXTENSION repmgr" to load this file. \quit
+\echo Use "ALTER EXTENSION repmgr UPDATE" to load this file. \quit

-DROP FUNCTION set_upstream_last_seen();
-
-CREATE FUNCTION set_upstream_last_seen(INT)
-  RETURNS VOID
-  AS 'MODULE_PATHNAME', 'set_upstream_last_seen'
-  LANGUAGE C STRICT;
-
-CREATE FUNCTION get_upstream_node_id()
-  RETURNS INT
-  AS 'MODULE_PATHNAME', 'get_upstream_node_id'
-  LANGUAGE C STRICT;
-
-CREATE FUNCTION set_upstream_node_id(INT)
-  RETURNS VOID
-  AS 'MODULE_PATHNAME', 'set_upstream_node_id'
-  LANGUAGE C STRICT;
+-- This script is intentionally empty and exists to skip the CREATE FUNCTION
+-- commands contained in the 4.3--4.4 extension upgrade script, which reference
+-- C functions which no longer exist in 5.3 and later.
+--
+-- These functions will be explicitly created in the 5.2--5.3 extension
+-- upgrade step with the correct C function references.
--- a/repmgr-client.c
+++ b/repmgr-client.c
@@ -51,6 +51,7 @@
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

+#include <pwd.h>
 #include <unistd.h>
 #include <sys/stat.h>
 #include <signal.h>
--- a/repmgr.conf.sample
+++ b/repmgr.conf.sample
@@ -69,7 +69,7 @@
 #------------------------------------------------------------------------------

 #replication_user='repmgr'	 # User to make replication connections with, if not set
-				 #  defaults to the user defined in "conninfo".
+				 # defaults to the user defined in "conninfo".

 #replication_type='physical'	 # Must "physical" (the default).

@@ -314,7 +314,7 @@ ssh_options='-q -o ConnectTimeout=10'	# Options to append to "ssh"
 #follow_command=''			# command repmgrd executes when instructing a standby to follow a new primary;
 					# use something like:
 					#
-					#     repmgr standby follow -f /etc/repmgr.conf -W --upstream-node-id=%n
+					#     repmgr standby follow -f /etc/repmgr.conf --upstream-node-id=%n
 					#
 #primary_notification_timeout=60	# Interval (in seconds) which repmgrd on a standby
 					# will wait for a notification from the new primary,
--- a/repmgr_version.h.in
+++ b/repmgr_version.h.in
@@ -1,7 +1,7 @@
 #define REPMGR_VERSION_DATE ""
-#define REPMGR_VERSION "5.3"
-#define REPMGR_VERSION_NUM 50300
+#define REPMGR_VERSION "5.3.1"
+#define REPMGR_VERSION_NUM 50301
 #define REPMGR_EXTENSION_VERSION "5.3"
 #define REPMGR_EXTENSION_NUM 50300
-#define REPMGR_RELEASE_DATE "2021-10-12"
+#define REPMGR_RELEASE_DATE "2022-02-15"
 #define PG_ACTUAL_VERSION_NUM 
--- a/repmgrd-physical.c
+++ b/repmgrd-physical.c
@@ -585,6 +585,7 @@ monitor_streaming_primary(void)

 			if (is_server_available(local_node_info.conninfo) == true)
 			{
+				close_connection(&local_conn);
 				local_conn = establish_db_connection(local_node_info.conninfo, false);

 				if (PQstatus(local_conn) != CONNECTION_OK)
@@ -1813,7 +1814,10 @@ monitor_streaming_standby(void)
 			if (upstream_check_result == true)
 			{
 				if (config_file_options.connection_check_type != CHECK_QUERY)
+				{
+					close_connection(&upstream_conn);
 					upstream_conn = establish_db_connection(upstream_node_info.conninfo, false);
+				}

 				if (PQstatus(upstream_conn) == CONNECTION_OK)
 				{
@@ -2546,8 +2550,10 @@ monitor_streaming_witness(void)
 			if (check_upstream_connection(&primary_conn, upstream_node_info.conninfo, NULL) == true)
 			{
 				if (config_file_options.connection_check_type != CHECK_QUERY)
+				{
+					close_connection(&primary_conn);
 					primary_conn = establish_db_connection(upstream_node_info.conninfo, false);
-
+				}
 				if (PQstatus(primary_conn) == CONNECTION_OK)
 				{
 					PQExpBufferData event_details;
@@ -3061,7 +3067,6 @@ do_primary_failover(void)

 				t_node_info new_primary = T_NODE_INFO_INITIALIZER;
 				RecordStatus record_status = RECORD_NOT_FOUND;
-				PGconn	   *new_primary_conn;

 				record_status = get_node_record(local_conn, new_primary_id, &new_primary);

@@ -3073,6 +3078,7 @@ do_primary_failover(void)
 				else
 				{
 					PQExpBufferData event_details;
+					PGconn	   *new_primary_conn;

 					initPQExpBuffer(&event_details);
 					appendPQExpBuffer(&event_details,
@@ -3093,7 +3099,6 @@ do_primary_failover(void)
 											  event_details.data);
 					close_connection(&new_primary_conn);
 					termPQExpBuffer(&event_details);
-
 				}
 				failover_state = FAILOVER_STATE_REQUIRES_MANUAL_FAILOVER;
 			}
Author	SHA1	Message	Date
Ian Barwick	78cc278639	docs: finalize release notes	2022-02-15 13:38:24 +09:00
Ian Barwick	ceb65027c6	Bump version number	2022-02-04 09:08:04 +09:00
Ian Barwick	e6caa14ea2	Bump version number 5.3.1	2022-02-03 14:48:47 +09:00
Ian Barwick	88a11f36ca	Add include for pwd.h This was previously included via the PostgreSQL source, but that seems to have gone away in recent HEAD builds.	2022-02-03 14:32:18 +09:00
Ian Barwick	7f371b11a5	doc: update version matrix 5.2.1 is the latest release in the 5.2.x series.	2022-02-03 13:30:29 +09:00
Ian Barwick	349eacd4b7	doc: update release notes	2022-02-03 13:29:32 +09:00
Ian Barwick	9f2afe9643	Fix upgrade paths from 4.1 ~ 4.3 to 5.2 and later A number of C functions were added in releases 4.2 to 4.4; however these were renamed in 5.3 to prevent naming clashes with other extensions. This does however mean that when upgrading from one of the above versions, the intermediate upgrade steps will attempt to create SQL functions referencing C functions which no longer exist in repmgr.so, and hence cause the upgrade to fail. We can work around this by providing empty upgrade scripts from these versions to 4.4, which skip the problematic CREATE FUNCTION commands. The functions will be correctly created in the 5.2--5.3 upgrade script.	2022-02-03 13:29:25 +09:00
Ian Barwick	356f65531f	repmgrd: move connection pointer declaration inside relevant block As it's used only there and nowhere else.	2022-01-04 12:46:50 +09:00
Ian Barwick	2a7579c770	doc: update release notes	2022-01-04 12:33:30 +09:00
zhouhj43183	820d972d41	repmgrd: ensure potentially open connections are closed When recovering from degraded state in local node monitoring, in some cases a new connection was opened to the local node without closing the old one, which will result in memory leakage.	2022-01-04 12:24:42 +09:00
Ian Barwick	d0add49c84	doc: update repmgr.conf.sample Minor formatting fix.	2021-12-08 09:52:27 +09:00
Ian Barwick	9a84fa84f9	doc: update repmgr.conf.sample Remove bogus -W option in "repmgr standby follow" example invocation for the "follow_command" parameter. The option (which corresponds to "--no-wait") is not used by "repmgr standby follow". Per report from Jimmy Angelakos.	2021-12-08 09:52:22 +09:00
Ian Barwick	ff2c56f5cb	doc: fix typo	2021-11-05 09:14:19 +09:00
Ian Barwick	3b860bad80	Removed temporary include file workaround	2021-10-29 15:44:16 +09:00
Ian Barwick	70c79aeaec	Add dummy include file This is a workaround required to facilitate Debian package builds against PostgreSQL Extended.	2021-10-12 16:50:33 +09:00
Ian Barwick	afd876377c	doc: repmgr 5.2 is no longer supported.	2021-10-12 14:05:41 +09:00
Ian Barwick	277910cb31	Fix version number	2021-10-12 13:50:22 +09:00
Ian Barwick	9554154677	doc: update version matrix	2021-10-12 13:49:28 +09:00